Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use /bin/bash in shebang #3338

Closed
wants to merge 1 commit into from
Closed

Use /bin/bash in shebang #3338

wants to merge 1 commit into from

Conversation

Daniel15
Copy link
Member

@Daniel15 Daniel15 commented May 6, 2017

Summary
Use /bin/bash as the shebang, as the script may use Bash-specific features.

Test plan
Run yarn with /bin/sh symlinked to /bin/dash and ensure it still works.

Closes #3321

@valpackett
Copy link

This is a terrible idea, /bin/bash is only available on GNU/Linux. This would break yarn on all of my machines, since they run FreeBSD. The real solution is to use [ instead of [[.

@Daniel15
Copy link
Member Author

Daniel15 commented May 6, 2017

@bestander Do you know why this was changed from [ to [[?

@bestander
Copy link
Member

It started complaining on my mac after I merged this #3245
No idea what I was doing there

@Daniel15
Copy link
Member Author

Daniel15 commented May 8, 2017

@myfreeweb Do you know how to fix #3260 without using [[? I'm not very familiar with shell scripting.

@valpackett
Copy link

@Daniel15 use = instead of -eq. = is for strings, -eq is for numbers

@Daniel15
Copy link
Member Author

Sounds good. Let's fix it the proper way.

@Daniel15 Daniel15 closed this May 10, 2017
bestander pushed a commit that referenced this pull request May 11, 2017
#3260 PR broke the `bin/yarn` shell script (see issue #3321)
#3338 tried to fix it in a improper way

This way should work.
Daniel15 pushed a commit that referenced this pull request May 12, 2017
#3260 PR broke the `bin/yarn` shell script (see issue #3321)
#3338 tried to fix it in a improper way

This way should work.
@Daniel15 Daniel15 deleted the Daniel15-patch-2 branch June 26, 2017 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants