Added a list sub-command for the yarn global command. Added unit test. #3308
+39
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This involved moving the list function out of the buildSubCommands so it could be called from ls & list. Calling global ls will display a warning that global ls is deprecated and to use global list.
|
There was a timeout issue in each of the failed tests, but they were different tests that failed and they were not related to my change (as far as I can tell)...what should I do to remedy? |
bestander
reviewed
May 12, 2017
| const lockfile = await Lockfile.fromDirectory(config.cwd); | ||
| const install = new Install({skipIntegrityCheck: true}, config, new NoopReporter(), lockfile); | ||
| const patterns = await install.init(); | ||
| reporter.warn(`\`yarn global ls\` is deprecated. Please use \`yarn global list\`.`); |
This was referenced Jun 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involved moving the list function out of the buildSubCommands so it could be called from ls & list.
Calling global ls will display a warning that global ls is deprecated and to use global list.
Summary
Changed the
yarn global lscommand toyarn global listto be inline with the non-global command, as per #3003.Test plan
Tests were updated to ensure that the output of
yarn global lsandyarn global listproduced the same results. Runningyarn run testverified the new test passed.