Fix User Namespace issues with untaring #2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawliet89
changed the title
|
Awesome! |
This was referenced Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a continuation of (and depends on) #2885 which re-fixes #1750 and friends. The bug was reintroduced with the switch to
tar-fsin #2826.Test plan
To test the fix for #2005, we need to run
yarn installas the root user. In addition, we also need to run it asrootbehind a user namespace. CircleCI has the set up we need.First, I added a commit on top of #2885 to prove that it fails.
Then, we can see that (other than some timeout test failure that already existed prior to this), it passes in this PR.
Alternatively, you can test this by setting up a Docker daemon with user namespace enabled. Then, checkout this branch,
yarn build, and try to do abin/yarn install.