fix: prevent from logging peer-dependencies that are met

[evenstensberg]

Summary

Solves the problem where peerDependencies are warning even though they are met.

Test plan

Run yarn add react react-dom

Before:

After:

I don't really know if the fix is legit. I removed a line of code, it may be doing something else than it was in my context, but the error is from lib/package-resolver.js L370, where it removes the peerDependencies we expect to have ( later adding the peerDep? ) . May need further investigation, but from the second check in lib/package-linker , it returns undefined for the package, since it has been removed from this.patterns. My suggestion, if this PR is somewhat volatile, is to check the packages you've got from the upper-tree against the ones you have, and then remove dupes.

Related:

• Unmet peer dependency warning when the peer dependency is installed at the same time #2132

If there's anything you need for me, feel free to assign me for other stuff.

Even

[bestander]

Looks like it is not that easy and broke some tests

[evenstensberg]

Yep. Assumed that! The bug might be more extensive than one might think. I ran yarn locally and it worked fine then, do you have an idea of what that might come from? The resolver is working as if should, but it may be that it gets the wrong information before resolving further layers upwards.

[bestander]

Looks like it broke cases when packages get updated, i.e. patterns are replaced.
Your change seems logical so maybe there is some replace logic down the line that relies on this.patterns not being deleted yet.

[evenstensberg]

I'll have a look at it tomorrow. It's doable to update packages as it is doing in multiple if loops in resolve packages I think