Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for cpu and os constraints if the arrays are not empty #2490

Merged
merged 2 commits into from
Jan 20, 2017
Merged

fix: check for cpu and os constraints if the arrays are not empty #2490

merged 2 commits into from
Jan 20, 2017

Conversation

bestander
Copy link
Member

Summary

fixes #2470

CPU and OS in package.json are checked only if they are not empty arrays.

Test plan

Added test

@bestander bestander mentioned this pull request Jan 18, 2017
Closed
@bestander bestander merged commit 93fa0f7 into yarnpkg:master Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpojer cpojer cpojer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"feed" module cannot be installed on OS X.
2 participants
@bestander @cpojer