Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a broken test for #2263 #2473

Merged
merged 1 commit into from
Jan 17, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions __tests__/commands/install/integration.js
Original file line number Diff line number Diff line change
Expand Up @@ -791,3 +791,13 @@ test.concurrent('a subdependency of an optional dependency that fails should be
assert.equal(await fs.exists(path.join(config.cwd, 'node_modules', 'sub-dep')), true);
});
});

// disabled while fix is not merged
test.skip('should not lose dependencies when installing with --production',
(): Promise<void> => {
// revealed https://github.com/yarnpkg/yarn/issues/2263
return runInstall({production: true}, 'prod-should-keep-subdeps', async (config) => {
assert.equal(await getPackageVersion(config,
'gulp/vinyl-fs/glob-stream/minimatch/brace-expansion/balanced-match'), '0.42.0');
});
});
10 changes: 10 additions & 0 deletions __tests__/fixtures/install/prod-should-keep-subdeps/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"dependencies": {
"gulp": "3.9.1"
},
"devDependencies": {
"eslint": ">=3.3.0",
"eslint-plugin-react": "3.5.1",
"stylelint": "^7"
}
}
Loading