Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on some code, and rather than including all my commits in one PR, I'd like to separate a few of the smaller, non-related fixes into their own PR's (for easier review).
Summary
Locally, I've upgraded my eslint versions, and the current
aliases
file throws lint errors due to thesort-keys
rule. This commit fixes the errors by sorting all our keys. I kept theshorthands
vsaffordances
separation by using 2 variables and the object spread syntax in the exported value.Test plan
yarn build
./bin/yarn ls
and a few other of the alias commands.yarn test
__tests__/cli/aliases.js
has no errors./coverage/lcov-report/index.html
src/cli/aliases.js
is still 100%