Add "Too many arguments" message to info and improve code coverage
#2235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skratchdot
commented
Dec 13, 2016
| @@ -47,7 +48,7 @@ const expectedKeys = [ | |||
| ]; | |||
|
|
|||
| test.concurrent('without arguments and in directory containing a valid package file', (): Promise<void> => { | |||
| return runInfo(['.'], {}, 'local', | |||
| return runInfo([], {}, 'local', | |||
There was a problem hiding this comment.
NOTE: this looks like I'm removing the ['.'] case, but there were actually 2 of the exact same test cases in this file. All I'm doing here is making this test case match the description (and hereby improving the coverage report).
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on some code, and rather than including all my commits in one PR, I'd like to separate a few of the smaller, non-related fixes into their own PR's (for easier review).
Summary
This is a very small change to get the code coverage of the
infocommand up to 100%. The currently included versions ofjestandbabel-jeststill have slightly incorrect coverage reports, but updating them gives100%on this file. I would like to upgrade all the modules in this repo, but it might make more sense for that to be in a different PR? (I didn't includepackage.jsonoryarn.lockupdates in this PR)Test plan
yarn test__tests__/commands/info.jshas no errorsopen ./coverage/lcov-report/index.htmlsrc/commands/info.jshas improved