-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable progress bar #1962
Disable progress bar #1962
Conversation
IMO, it's better to handle it in |
Config file vs package.json seems to come down to preference. I would opt for both. The react-boilerplate project makes a point of keeping the project root as clean as practical. That's nice but it adds a lot of complexity to package.json. This choice is enabled by packages that support both options, eslint for example. |
@gihrig I wasn't talking about config file in project folder but global config. Is there any use case where you want to disable progress only for a specific repo? |
@torifat Probly not. I have npm progress bar disabled in global config and never wanted otherwise. So I agree, on second thought, package json makes little sense. |
@torifat Will refactor this to use |
@torifat This has been refactored to use yarn config |
LGTM cc @bestander |
Summary
Per #1956, this enables users to specify a JSON key, noProgress, in their package.json to disable the progress bar from showing.
Test plan
Small refactor for testability, created
__tests__/cli/index.js
file and tests for addition.Using feature
Adding the following the
package.json
will disable progress bar output:"noProgress": true,