Create lockfile when missing even when integrity hash matches #1888
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This solves #1876. Before, if integrity hash from disk matched the calculated hash from the patterns from the manifest, then it would bail on the rest of the installation. Added a check to not bail out if the
yarn.lock
file does not exist. This was a regression in0.17.x
as it would create it if missing in0.16.x
.Test plan
Setup
Before
$ yarn yarn install v0.17.2 info No lockfile found. warning No license field [1/4] 🔍 Resolving packages... success Already up-to-date. ✨ Done in 0.59s. $ ls node_modules package.json
After
$ yarn yarn install v0.18.0-0 info No lockfile found. warning No license field [1/4] 🔍 Resolving packages... [2/4] 🚚 Fetching packages... [3/4] 🔗 Linking dependencies... [4/4] 📃 Building fresh packages... success Saved lockfile. ✨ Done in 0.46s. $ ls node_modules package.json yarn.lock