Fix --mutex #1717
Merged
Fix --mutex #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bestander
pushed a commit
to bestander/yarn
that referenced
this pull request
Nov 9, 2016
* Fix --mutex, pass specifier through to repeated promise calls. * Minor grammar fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes --mutex, which currently doesn't pass the file specifier into repeated calls, and so multiple parallel calls don't correctly exclude one another.
Test plan
Tested via running:
For packages with a reasonable number of dependencies, this fails pretty reliably on master with various errors from
~/.cache/yarn. After this change there are many messages about waiting for the other yarns to finish, and all then complete successfully.