Warn when man or bin directory not found but don't crash #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmck
suggested changes
Nov 4, 2016
| for (const scriptName of await fs.readdir(path.join(moduleLoc, binDir))) { | ||
| if (scriptName[0] === '.') { | ||
| continue; | ||
| try { |
There was a problem hiding this comment.
Could we do await fs.exists() here instead of the try-catch? Seems much nicer.
There was a problem hiding this comment.
fs.exists is deprecated. I'm not sure how long it has been deprecated and the other options of fs.stat() or fs.access() seem like they would have the same problem of having the error thrown.
| for (const filename of await fs.readdir(path.join(moduleLoc, manDir))) { | ||
| if (/^(.*?)\.[0-9]$/.test(filename)) { | ||
| man.push(path.join('.', manDir, filename)); | ||
| try { |
|
@kittens: Changes per the review are done. Thanks for the input. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes situation where the bin or man directory is specified in the package.json but does not really exist. This change is to address issues like #739
Test plan
yarn add newman@3.2.0 succeeds to install. Previously when installing dependency postman-collection@0.5.5 yarn would crash with an ENOENT trying to read the bin directory that doesn't exist.