Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-761: do not ignore devDeps that are included as in prod pkg (#761) #1626

Closed
wants to merge 4 commits into from
Closed

fix-761: do not ignore devDeps that are included as in prod pkg (#761) #1626

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 3, 2016

Summary

When installing with production flag the devDeps also follow the flow, but are set to ignored. Chances are that a production dependency can be smartly resolved and shared with a devDep. If this is the case make sure this package also gets set to USED when being included, so it won't be ignored later.

This solves at least:

Test plan

npm run test should not give errors and contain a new use-case for these cases.

Extracted & tested use-case from the issue:

$ git clone https://github.com/donovan-graham/yarn-example-app.git
$ cd yarn-example-app

Should resolve and give the correct dependencies:

$ yarn install --production
$ yarn check --production
$ yarn check --production --integrity
$ npm run start

@ghost ghost changed the title fix-761: do not ignore devDeps that are included as in prod pkg fix-761: do not ignore devDeps that are included as in prod pkg (#761) Nov 3, 2016
@ghost
Copy link
Author

ghost commented Nov 8, 2016

Closing in favour for possible better solutions. More (other) issues are related as-well to inheriting and propagating visibility.

@ghost ghost closed this Nov 8, 2016
@ghost ghost deleted the fix-761-production-with-devdeps branch November 14, 2016 22:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants