Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fs.copyFile #4331

Closed
cpojer opened this issue Sep 7, 2017 · 0 comments · Fixed by #4486
Closed

Use fs.copyFile #4331

cpojer opened this issue Sep 7, 2017 · 0 comments · Fixed by #4486
Labels
cat-feature triaged

Comments

@cpojer
Copy link
Contributor

cpojer commented Sep 7, 2017

This should be much faster on systems like macos High Sierra. Let's feature detect it and support it: nodejs/node#15034
BYK added a commit that referenced this issue Sep 16, 2017
@BYK
Update: use fs.copyFile when awailable
8ac7c00 
**Summary**

Fixes #4331. Supercedes #3290. Uses the newly added `fs.copyFile`
on Node 8.5 hen available and falls back to old buffer based
method otherwise. This patch also refactors the file copy code a
bit making it more efficient. Here are the durations on my computer
with [this package.json](https://github.com/sciolist/fcopy/blob/c0ded8b82bbaa3f4cdb0a67e951eb3f8b0f97fb7/perf/project/alottafiles/package.json):

| master | w/o fsCopy | w/ fsCopy |
| ~23s | ~19s | ~15s |

This is with `yarn.lock` in place and w/o `node_modules`.

**Test plan**

CI should pass.
@BYK BYK mentioned this issue Sep 16, 2017
Merged
BYK added a commit that referenced this issue Sep 16, 2017
@BYK
Update: use fs.copyFile when available
110d43a 
**Summary**

Fixes #4331. Supercedes #3290. Uses the newly added `fs.copyFile`
on Node 8.5 hen available and falls back to old buffer based
method otherwise. This patch also refactors the file copy code a
bit making it more efficient. Here are the durations on my computer
with [this package.json](https://github.com/sciolist/fcopy/blob/c0ded8b82bbaa3f4cdb0a67e951eb3f8b0f97fb7/perf/project/alottafiles/package.json):

| master | w/o fsCopy | w/ fsCopy |
| - | - | - |
| ~23s | ~19s | ~15s |

This is with `yarn.lock` in place and w/o `node_modules`.

**Test plan**

CI should pass.
@BYK BYK closed this as completed in #4486 Sep 18, 2017
BYK added a commit that referenced this issue Sep 18, 2017
@BYK
Update: use fs.copyFile when available (#4486)
0ee1c55 
**Summary**

Fixes #4331. Supersedes #3290. Uses the newly added `fs.copyFile` 
on Node 8.5 hen available and falls back to the old buffer based 
method otherwise. This patch also refactors the file copy code a 
bit making it more efficient. Here are the durations on my computer 
with [this package.json](https://github.com/sciolist/fcopy/blob/c0ded8b82bbaa3f4cdb0a67e951eb3f8b0f97fb7/perf/project/alottafiles/package.json):

| master | w/o copyFile | w/ copyFile |
| - | - | - |
| ~23s | ~19s | ~14s |

This is with `yarn.lock` in place and w/o `node_modules`.

**Test plan**

CI should pass.
joaolucasl pushed a commit to joaolucasl/yarn that referenced this issue Oct 27, 2017
@BYK @joaolucasl
Update: use fs.copyFile when available (yarnpkg#4486)
11be389 
**Summary**

Fixes yarnpkg#4331. Supersedes yarnpkg#3290. Uses the newly added `fs.copyFile` 
on Node 8.5 hen available and falls back to the old buffer based 
method otherwise. This patch also refactors the file copy code a 
bit making it more efficient. Here are the durations on my computer 
with [this package.json](https://github.com/sciolist/fcopy/blob/c0ded8b82bbaa3f4cdb0a67e951eb3f8b0f97fb7/perf/project/alottafiles/package.json):

| master | w/o copyFile | w/ copyFile |
| - | - | - |
| ~23s | ~19s | ~14s |

This is with `yarn.lock` in place and w/o `node_modules`.

**Test plan**

CI should pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cat-feature triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update: use fs.copyFile when available yarnpkg/yarn
2 participants
@cpojer @BYK