Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update cross-spawn to v7.0.6 #6605

Closed
wants to merge 1 commit into from

Conversation

dargmuesli
Copy link

@dargmuesli dargmuesli commented Nov 19, 2024

What's the problem this PR addresses?

There's a Regular Expression Denial of Service (ReDoS) in cross-spawn >= 7.0.0, < 7.0.5; < 6.0.6

How did you fix it?

Update cross-spawn to v7.0.6, including all transitive dependencies

Checklist

  • I have read the Contributing Guide.

  • I have set the packages that need to be released for my changes to be effective.

  • I will check that all automated PR checks pass before the PR gets reviewed.

@dargmuesli dargmuesli force-pushed the chore/deps/cross-spawn branch from ae077c7 to 7f6fc35 Compare November 19, 2024 04:04
Copy link
Member

@merceyz merceyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on moxystudio/node-cross-spawn#160 this seems unlikely to be an issue we should be concerned about.

including all transitive dependencies

That's unnecessary.

Comment on lines 1 to 4
releases:
"@yarnpkg/builder": patch
"@yarnpkg/cli": patch
"@yarnpkg/core": patch
"@yarnpkg/doctor": patch
"@yarnpkg/extensions": patch
"@yarnpkg/nm": patch
"@yarnpkg/plugin-compat": patch
"@yarnpkg/plugin-constraints": patch
"@yarnpkg/plugin-dlx": patch
"@yarnpkg/plugin-essentials": patch
"@yarnpkg/plugin-exec": patch
"@yarnpkg/plugin-file": patch
"@yarnpkg/plugin-git": patch
"@yarnpkg/plugin-github": patch
"@yarnpkg/plugin-http": patch
"@yarnpkg/plugin-init": patch
"@yarnpkg/plugin-interactive-tools": patch
"@yarnpkg/plugin-link": patch
"@yarnpkg/plugin-nm": patch
"@yarnpkg/plugin-npm": patch
"@yarnpkg/plugin-npm-cli": patch
"@yarnpkg/plugin-pack": patch
"@yarnpkg/plugin-patch": patch
"@yarnpkg/plugin-pnp": patch
"@yarnpkg/plugin-pnpm": patch
"@yarnpkg/plugin-stage": patch
"@yarnpkg/plugin-typescript": patch
"@yarnpkg/plugin-version": patch
"@yarnpkg/plugin-workspace-tools": patch
"@yarnpkg/pnpify": patch
"@yarnpkg/sdks": patch
"@yarnpkg/shell": patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only need a patch release on core, shell, and the cli.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated ✅

@dargmuesli dargmuesli force-pushed the chore/deps/cross-spawn branch from 7f6fc35 to 3798ef8 Compare November 19, 2024 09:58
@dargmuesli
Copy link
Author

dargmuesli commented Nov 19, 2024

That's unnecessary.

I'd argue it's necessary as without updating cross-spawn in all places, the vulnerability could be triggered in a transitive dependency. Although I agree this is unlikely. It just appeared doable to update the dependency, so I thought I propose this change.

@merceyz
Copy link
Member

merceyz commented Nov 25, 2024

Thanks for the PR but I'll close this since it isn't a vulnerability we need to worry about and with #6606 merged and released consumers of the npm packages can get the patched version of cross-spawn.

@merceyz merceyz closed this Nov 25, 2024
@dargmuesli dargmuesli deleted the chore/deps/cross-spawn branch November 25, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants