refactor!: remove lockfileFilename
#5604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
1 task
nicknovitski
added a commit
to nicknovitski/yarn-plugin-nixify
that referenced
this pull request
Oct 10, 2023
This field will be removed from yarn in version 4: yarnpkg/berry#5604 With this change, the plugin works with the current canary release, v4.0.0-rc.53.
nicknovitski
added a commit
to nicknovitski/yarn-plugin-nixify
that referenced
this pull request
Oct 10, 2023
This field will be removed from yarn in version 4: yarnpkg/berry#5604 With this change, the plugin works with the current canary release, v4.0.0-rc.53.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
lockfileFilenameis a configuration option that provides little value and overcomplicates other parts of the codebase.Many third-party tools aren't even aware of it and even we have parts of the codebase that completely ignore it and use
yarn.lock.It also complicates project detection, as we first need to instantiate the configuration before being able to walk up the filesystem to find the project root.
How did you fix it?
Removed it.
Configuration.findProjectCwdcould also use a different signature but I'll leave it for a different PR since I intend to refactor it anyways.Checklist