refactor(core)!: replace workspace.dependencies
with worskpace.anchoredPackage
#4898
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
I don't like
workspace.dependencies
because theProject
class has to manually keep it in sync (and historically it hasn't done a good job).How did you fix it?
I removed it and added a new
workspace.anchoredPackage
getter that can be used in more situations.Since there is only one production codepath using
workspace.dependencies
and it accesses it a single time, the lack of caching forworkspace.anchoredPackage
doesn't affect its performance.Checklist