Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core)!: remove MapConfigurationValue #4645

Merged
merged 2 commits into from
Jul 20, 2022
Merged

refactor(core)!: remove MapConfigurationValue #4645

merged 2 commits into from
Jul 20, 2022

Conversation

paul-soporan
Copy link
Member

What's the problem this PR addresses?

This PR removes the deprecated MapConfigurationValue type.

miscUtils.ToMapValue should be used instead.

How did you fix it?

Removed it.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@paul-soporan paul-soporan requested a review from arcanis as a code owner July 20, 2022 03:01
@paul-soporan paul-soporan mentioned this pull request Jul 20, 2022
Closed
13 tasks
@arcanis arcanis merged commit 4e855d4 into master Jul 20, 2022
@arcanis arcanis deleted the paul/refactor/remove-map-configuration-value branch July 20, 2022 07:55
@merceyz merceyz added this to the 4.0.0 milestone May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcanis arcanis Awaiting requested review from arcanis

Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@paul-soporan @arcanis @merceyz