Skip to content

Don't run the tests anymore on Node 12 #4196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2022
Merged

Don't run the tests anymore on Node 12 #4196

merged 3 commits into from
Mar 10, 2022

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Mar 8, 2022

What's the problem this PR addresses?

Yarn 4 won't support Node 12.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

Copy link
Member

@merceyz merceyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we set the lowest version to the first LTS release (14.15.0)?

A few more places to update

@arcanis arcanis requested a review from merceyz March 8, 2022 12:36
@merceyz merceyz mentioned this pull request Mar 8, 2022
13 tasks
@arcanis arcanis merged commit 0da2581 into master Mar 10, 2022
@arcanis arcanis deleted the mael/test-coverage branch March 10, 2022 09:27
@merceyz merceyz added the major label May 26, 2022
@merceyz merceyz added this to the 4.0.0 milestone May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants