Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compat): update patch for typescript@4.6.0-beta #3978

Merged
merged 5 commits into from
Jan 23, 2022

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jan 14, 2022

What's the problem this PR addresses?

The PnP compatibility patch for TypeScript doesn't apply to typescript@>=4.6.0-beta.

How did you fix it?

Rebased microsoft/TypeScript#35206 onto the 4.6.0-beta release

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz changed the title fix(compat): update patch for typescript 4.6 fix(compat): update patch for typescript@4.6.0-beta Jan 22, 2022
@merceyz merceyz marked this pull request as ready for review January 22, 2022 01:52
range: `>=4.5.2`,
from: `9232978f8e54f073b5451d0bf2737d42a0fd672f`,
to: `3a2388d39d41d000b5c5f9bcd48096b39fcedf8f`,
onto: `55e13e9115b3cc5458d76c39da1211dc28d7b51f`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you need to change the from/to/onto?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There has been a few releases for 4.5 since we last generated the patch so I updated my branch, I'll revert it since it isn't strictly needed.

@arcanis arcanis merged commit ab0831d into master Jan 23, 2022
@arcanis arcanis deleted the merceyz/fix/compat-ts-4-6 branch January 23, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants