Make yarn work inside a workspace with "type": "module" #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures the file will correctly load in all workspaces, regardless of their "type". Fixes yarnpkg#985
Right now the command can fail if the temporary folder contains a package.json with `"type": "module"`.
bgotink
added a commit
to bgotink/yarn
that referenced
this pull request
May 21, 2020
This improves the experience of working with yarn in workspaces that are marked as "type": "module" in the package.json file. This change has also been applied in yarn 2, see yarnpkg/berry#1354
arcanis
pushed a commit
to yarnpkg/yarn
that referenced
this pull request
May 25, 2020
This improves the experience of working with yarn in workspaces that are marked as "type": "module" in the package.json file. This change has also been applied in yarn 2, see yarnpkg/berry#1354
arcanis
pushed a commit
to yarnpkg/yarn
that referenced
this pull request
Aug 27, 2020
This improves the experience of working with yarn in workspaces that are marked as "type": "module" in the package.json file. This change has also been applied in yarn 2, see yarnpkg/berry#1354
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Yarn doesn't work inside workspaces with
"type": "module".Fixes #985
How did you fix it?
Switch the yarn releases from
.jsto.cjsfile extension. This marks the file as always being CommonJS, regardless of the surrounding workspace's type.The same change should be done in yarn v1, given that a lot of people will keep using v1 as global yarn for the foreseeable future.
Future work?
Right now we store the PnP file as
.pnp.jsfor regular workspaces, and as.pnp.cjsfor workspaces markedtype=module. There are some downsides to this approach:.pnp.jsfile, they will need to also check for.pnp.cjs.yarn && yarn pnpify --sdkand reload your IDE.Always using
.pnp.cjsremoves these downsides.