Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Go-to Definition fails in VSCode 1.61 #3539

Closed
1 task
YXL76 opened this issue Oct 8, 2021 · 5 comments · Fixed by #3555
Closed
1 task

[Bug]: Go-to Definition fails in VSCode 1.61 #3539

YXL76 opened this issue Oct 8, 2021 · 5 comments · Fixed by #3555
Labels
bug Something isn't working

Comments

@YXL76
Copy link

YXL76 commented Oct 8, 2021

Self-service

  • I'd be willing to implement a fix

Describe the bug

After updating vscode to 1.61.0, the go-to definition gets error.

Unable to open 'fs.d.ts': Unable to read file '/^zip:/home/yxl/yarn-zipfs-bug/.yarn/cache/@types-node-npm-16.10.3-ae1d2f8739-3fd429bce8.zip/node_modules/@types/node/fs.d.ts' (Error: Unable to resolve nonexistent file '/^zip:/home/yxl/yarn-zipfs-bug/.yarn/cache/@types-node-npm-16.10.3-ae1d2f8739-3fd429bce8.zip/node_modules/@types/node/fs.d.ts').

To reproduce

I create a repo for this:
yarn-zipfs-bug

Environment

System:
  OS: Linux 5.14 Arch Linux
  CPU: (8) x64 Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
Binaries:
  Node: 14.17.4 - /tmp/xfs-62e53485/node
  Yarn: 3.1.0-rc.8 - /tmp/xfs-62e53485/yarn
  npm: 7.24.2 - /usr/bin/npm

Additional context

No response

@YXL76 YXL76 added the bug Something isn't working label Oct 8, 2021
@arcanis
Copy link
Member

arcanis commented Oct 8, 2021

Tracked on VSCode at microsoft/vscode#134304

I'm working on updating the SDK, but some of those new path formats are a little strange and may require some time to get right

@wlewis-formative
Copy link

Thanks, @arcanis! In the mean time, the August 2021 release of VSCode is working for me: https://code.visualstudio.com/updates/v1_60.

@stavalfi
Copy link

stavalfi commented Oct 13, 2021

Thanks, @arcanis! In the mean time, the August 2021 release of VSCode is working for me: https://code.visualstudio.com/updates/v1_60.

Thanks man! I confirm that this is a termporary workaround which works.

@merceyz
Copy link
Member

merceyz commented Oct 14, 2021

The fix has been released, you can run the following to update the SDK

yarn dlx @yarnpkg/sdks

@bradennapier
Copy link

It doesnt seem to work - every time i run it, it says it updated to the vscode version but clearly it doesnt because running again yields same resul tand zipfs doesn twork?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants