ci: fix the create-react-app e2e test (#3988)

* ci: fix the `create-react-app` e2e test * chore: remove resolution from storybook e2e
yarnpkg · Jan 24, 2022 · c477f41 · c477f41
1 parent 6e1446e
commit c477f41
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/.github/workflows/e2e-cra-workflow.yml b/.github/workflows/e2e-cra-workflow.yml
@@ -25,14 +25,23 @@ jobs:
       run: |
         source scripts/e2e-setup-ci.sh
         yarn dlx create-react-app my-cra && cd my-cra
-        yarn add -D eslint-config-react-app
+
+        # TODO: Remove when create-react-app fixes their ESLint setup
+        yarn add -D eslint-config-react-app eslint
+
         yarn build
 
     - name: 'Running the TypeScript integration test'
       run: |
         source scripts/e2e-setup-ci.sh
         yarn dlx create-react-app my-cra-ts --template typescript && cd my-cra-ts
-        yarn add -D eslint-config-react-app
+
+        # TODO: Remove when create-react-app fixes their ESLint setup
+        yarn add -D eslint-config-react-app eslint
+
+        # TODO: Remove when https://github.com/facebook/create-react-app/pull/11751 is released
+        yarn add -D @types/testing-library__jest-dom
+
         yarn build
       if: |
         always()
diff --git a/.github/workflows/e2e-storybook-workflow.yml b/.github/workflows/e2e-storybook-workflow.yml
@@ -26,7 +26,10 @@ jobs:
       run: |
         source scripts/e2e-setup-ci.sh
         yarn dlx create-react-app my-cra && cd my-cra
-        yarn add -D eslint-config-react-app
+
+        # TODO: Remove when create-react-app fixes their ESLint setup
+        yarn add -D eslint-config-react-app eslint
+
         yarn dlx -p @storybook/cli@next sb init --yes
         yarn build-storybook