Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

793 configure simulation run #920

Merged
merged 14 commits into from
Apr 20, 2023
Merged

793 configure simulation run #920

merged 14 commits into from
Apr 20, 2023

Conversation

Derstilon
Copy link
Member

image
image

@Derstilon Derstilon marked this pull request as draft April 14, 2023 16:59
@grzanka
Copy link
Contributor

grzanka commented Apr 17, 2023

@Derstilon does it make sense to test it now ?

…ation-run

# Conflicts:
#	src/ThreeEditor/components/Sidebar/propeteries/category/ZoneOperations.tsx
#	src/ThreeEditor/components/Sidebar/tree/SidebarTreeItem.tsx
#	src/WrapperApp/components/Simulation/SimulationPanel.tsx
#	src/WrapperApp/components/Simulation/SimulationPanelGrid.tsx
#	src/WrapperApp/components/Simulation/SimulationProgressBar.tsx
@Derstilon Derstilon force-pushed the 793-configure-simulation-run branch from 86076e7 to e5f546a Compare April 18, 2023 13:46
@Derstilon Derstilon requested review from grzanka and ostatni5 April 18, 2023 13:49
@Derstilon Derstilon marked this pull request as ready for review April 18, 2023 13:49
@grzanka grzanka linked an issue Apr 18, 2023 that may be closed by this pull request
2 tasks
@grzanka grzanka enabled auto-merge April 18, 2023 17:10
@grzanka grzanka disabled auto-merge April 18, 2023 17:10
grzanka
grzanka previously approved these changes Apr 18, 2023
Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Member

@ostatni5 ostatni5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok but it could be better
image

src/ThreeEditor/js/Editor.js Outdated Show resolved Hide resolved
src/WrapperApp/components/Simulation/RunSimulationForm.tsx Outdated Show resolved Hide resolved
src/WrapperApp/components/Simulation/SimulationPanel.tsx Outdated Show resolved Hide resolved
src/WrapperApp/components/Simulation/SimulationPanel.tsx Outdated Show resolved Hide resolved
src/services/ShSimulatorService.tsx Outdated Show resolved Hide resolved
@Derstilon Derstilon force-pushed the 793-configure-simulation-run branch from 48d41e0 to 70f310e Compare April 19, 2023 13:06
@Derstilon Derstilon requested a review from ostatni5 April 19, 2023 13:18
@Derstilon Derstilon added this pull request to the merge queue Apr 20, 2023
Merged via the queue into master with commit 97bd637 Apr 20, 2023
@Derstilon Derstilon deleted the 793-configure-simulation-run branch April 20, 2023 08:42
@Derstilon Derstilon added the EuroHPC features created within EuroHPC project label Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EuroHPC features created within EuroHPC project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure parallelism of the simulations
3 participants