Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drag and drop files #904

Merged
merged 7 commits into from
Apr 17, 2023
Merged

Conversation

ostatni5
Copy link
Member

@ostatni5 ostatni5 commented Apr 5, 2023

No description provided.

@ostatni5 ostatni5 self-assigned this Apr 5, 2023
@ostatni5 ostatni5 linked an issue Apr 5, 2023 that may be closed by this pull request
@grzanka
Copy link
Contributor

grzanka commented Apr 5, 2023

Try following test:

  1. Open UI as it is on your branch
  2. Open yaptide UI editor, and load a project from following JSON: https://gist.githubusercontent.com/grzanka/cd47cacce2f6d5986397630d76580d11/raw/e6ca6a23fbae78b04ddcfaf2582bc7c3f972e995/2022let_plan2.json
  3. Go to "Input files" and click "Generate from editor". Several files will appear there, one of them will be sobp.dat.
  4. Now, on Windows, I find some directory with 4 usual input files (beam.dat, geo.dat, detect.dat and mat.dat). I drag and drop these files into the yaptide UI.
  5. I would expect that sobp.dat disappears, but thats not the case, it is still there.

@grzanka
Copy link
Contributor

grzanka commented Apr 5, 2023

Another exercise:

  1. Generate input files as in the comment above
  2. Clear all the files
  3. Move just one (mat.dat) files into drag and drop
  4. Suddenly all the files all populated, despite the fact I've cleaned them
    https://user-images.githubusercontent.com/7374733/230183049-4777c271-6c23-4e28-8173-553a0ee12ad3.mp4

@grzanka
Copy link
Contributor

grzanka commented Apr 5, 2023

I am happy to stay with the situation that uploading new files is not removing the old files. But in such case I would like to see a good option to remove only part of the files or all of them. Cleaning seems not to work properly

@grzanka grzanka requested review from Derstilon and grzanka April 17, 2023 08:50
grzanka
grzanka previously approved these changes Apr 17, 2023
@grzanka
Copy link
Contributor

grzanka commented Apr 17, 2023

@Derstilon please review as well, to me it looks OK

@grzanka grzanka enabled auto-merge April 17, 2023 13:47
@grzanka grzanka added this pull request to the merge queue Apr 17, 2023
Merged via the queue into master with commit f0aedd4 Apr 17, 2023
@grzanka grzanka deleted the 874-drag-and-drop-for-simulation-input-files branch April 17, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag and drop for simulation input files
3 participants