Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing params to Scoring Output Types #899

Merged
merged 3 commits into from
Apr 3, 2023
Merged

Added missing params to Scoring Output Types #899

merged 3 commits into from
Apr 3, 2023

Conversation

kacper1409
Copy link
Collaborator

@kacper1409 kacper1409 requested a review from grzanka April 3, 2023 18:57
@kacper1409 kacper1409 self-assigned this Apr 3, 2023
@kacper1409 kacper1409 linked an issue Apr 3, 2023 that may be closed by this pull request
Scoring Qeff #864
Closed
@kacper1409
Copy link
Collaborator Author

I checked for each of added params that after selecting it from dropdown list, there is proper output in detect.dat.

grzanka
grzanka requested changes Apr 3, 2023
View reviewed changes
src/ThreeEditor/util/Scoring/ScoringOutputTypes.ts Outdated Show resolved Hide resolved
src/ThreeEditor/util/Scoring/ScoringOutputTypes.ts Outdated Show resolved Hide resolved
src/ThreeEditor/util/Scoring/ScoringOutputTypes.ts Outdated Show resolved Hide resolved
kacper1409 and others added 2 commits April 3, 2023 22:37
@kacper1409 @grzanka
Apply suggestions from code review
26ee5d5 
Co-authored-by: Leszek Grzanka <grzanka@agh.edu.pl>
@kacper1409
readme update
2fc6df8
grzanka
grzanka approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grzanka grzanka added this pull request to the merge queue Apr 3, 2023
Merged via the queue into master with commit bba510a Apr 3, 2023
@grzanka grzanka deleted the 864-scoring-qeff branch April 3, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzanka grzanka grzanka approved these changes

Assignees

@kacper1409 kacper1409

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scoring Qeff
2 participants
@kacper1409 @grzanka