Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing github pages deploy #848

Merged
merged 1 commit into from
Mar 14, 2023
Merged

fixing github pages deploy #848

merged 1 commit into from
Mar 14, 2023

Conversation

grzanka
Copy link
Contributor

@grzanka grzanka commented Mar 13, 2023 •
edited
Loading

It seems that upgrading glob done in #827 broke out github pages deploy.
Current version of glob seems to return Promise by default. Therefore simplifying the code could fix the issue with not working converter on demo version

@grzanka grzanka linked an issue Mar 13, 2023 that may be closed by this pull request
Unexpected token '<', "<!DOCTYPE "... is not valid JSON #840
Closed
@grzanka grzanka requested review from ostatni5 and Derstilon March 13, 2023 20:05
@grzanka grzanka enabled auto-merge March 13, 2023 20:06
@grzanka grzanka self-assigned this Mar 13, 2023
Derstilon
Derstilon approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@Derstilon Derstilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if any future errors won't be handled properly by glob functionwe could add catch closure to handle those errors

@grzanka grzanka added this pull request to the merge queue Mar 14, 2023
Merged via the queue into master with commit 68d69f0 Mar 14, 2023
@grzanka grzanka deleted the 840-unexpected-token-doctype-is-not-valid-json branch March 14, 2023 16:32
@Derstilon Derstilon added the EuroHPC features created within EuroHPC project label Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Derstilon Derstilon Derstilon approved these changes

@ostatni5 ostatni5 Awaiting requested review from ostatni5

Assignees

@grzanka grzanka

Labels
EuroHPC features created within EuroHPC project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected token '<', "<!DOCTYPE "... is not valid JSON
2 participants
@grzanka @Derstilon