-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
822 geometry of patient body #847
Conversation
src/ThreeEditor/components/Sidebar/propeteries/category/CTConfiguration.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a lot of files with a same construction
<PropertiesCategory visible={visibleFlag}>
{visibleFlag && (<Smth/>)}
</PropertiesCategory>
Is it possible to implement visibleFlag condition inside of Properties Category implementation?
Something like this:
return (
<ReguralContentsOfPropertiesCategory>
{visible && (props.children)}
</ReguralContentsOfPropertiesCategory>
)
Well probably it is possible but I remember there was some problems with such solution. Make for it another issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments inline
@ostatni5 rebase onto newest master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Co-authored-by: Jakub Niechaj <quban123@gmail.com>
Co-authored-by: Jakub Niechaj <quban123@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add CT:
Preview CT:
POC resultCT: