Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

822 geometry of patient body #847

Merged
merged 10 commits into from
Apr 16, 2023
Merged

822 geometry of patient body #847

merged 10 commits into from
Apr 16, 2023

Conversation

ostatni5
Copy link
Member

Add CT:
image

Preview CT:
image

POC resultCT:
image

@ostatni5 ostatni5 requested a review from grzanka March 10, 2023 18:04
@ostatni5 ostatni5 self-assigned this Mar 10, 2023
@ostatni5 ostatni5 linked an issue Mar 10, 2023 that may be closed by this pull request
src/JsRoot/GraphData.tsx Outdated Show resolved Hide resolved
Copy link
Member

@Derstilon Derstilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a lot of files with a same construction

<PropertiesCategory visible={visibleFlag}>
	{visibleFlag && (<Smth/>)}
</PropertiesCategory>

image

Is it possible to implement visibleFlag condition inside of Properties Category implementation?
Something like this:

return (
	<ReguralContentsOfPropertiesCategory>
		{visible && (props.children)}
	</ReguralContentsOfPropertiesCategory>
)

@ostatni5
Copy link
Member Author

We have a lot of files with a same construction

<PropertiesCategory visible={visibleFlag}>
	{visibleFlag && (<Smth/>)}
</PropertiesCategory>

image

Is it possible to implement visibleFlag condition inside of Properties Category implementation? Something like this:

return (
	<ReguralContentsOfPropertiesCategory>
		{visible && (props.children)}
	</ReguralContentsOfPropertiesCategory>
)

Well probably it is possible but I remember there was some problems with such solution. Make for it another issue.

src/JsRoot/GraphData.tsx Outdated Show resolved Hide resolved
src/JsRoot/GraphData.tsx Outdated Show resolved Hide resolved
@ostatni5 ostatni5 requested a review from Derstilon March 27, 2023 17:43
Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/JsRoot/GraphData.tsx Outdated Show resolved Hide resolved
src/JsRoot/GraphData.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments inline

@grzanka
Copy link
Contributor

grzanka commented Mar 29, 2023

@ostatni5 rebase onto newest master

@ostatni5 ostatni5 requested a review from grzanka April 4, 2023 20:15
grzanka
grzanka previously approved these changes Apr 5, 2023
Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

src/JsRoot/GraphData.tsx Outdated Show resolved Hide resolved
Co-authored-by: Jakub Niechaj <quban123@gmail.com>
Co-authored-by: Jakub Niechaj <quban123@gmail.com>
Copy link
Member

@Derstilon Derstilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image LGTM

@ostatni5 ostatni5 requested a review from Derstilon April 16, 2023 16:02
@ostatni5 ostatni5 added this pull request to the merge queue Apr 16, 2023
Merged via the queue into master with commit 7883274 Apr 16, 2023
@ostatni5 ostatni5 deleted the 822-geometry-of-patient-body branch April 16, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geometry of Patient body
3 participants