Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sigma to UI #712

Merged
merged 3 commits into from
Nov 11, 2022
Merged

add sigma to UI #712

merged 3 commits into from
Nov 11, 2022

Conversation

ostatni5
Copy link
Member

@ostatni5 ostatni5 commented Nov 9, 2022

Waiting for yaptide/converter#87

@ostatni5 ostatni5 self-assigned this Nov 9, 2022
@ostatni5 ostatni5 linked an issue Nov 9, 2022 that may be closed by this pull request
@grzanka
Copy link
Contributor

grzanka commented Nov 10, 2022

@ostatni5 can you rebase it on the top of new converter ?
I've just merged #717

@grzanka
Copy link
Contributor

grzanka commented Nov 10, 2022

image

"Radius in X" should be renamed to "Radius"

@grzanka
Copy link
Contributor

grzanka commented Nov 10, 2022

InputEditorPanel.tsx:62 PythonError: Traceback (most recent call last):
  File "<exec>", line 7, in convertJson
  File "/lib/python3.10/site-packages/converter/api.py", line 35, in run_parser
    return parser.get_configs_json()
  File "/lib/python3.10/site-packages/converter/shieldhit/parser.py", line 48, in get_configs_json
    "beam.dat": str(self.beam_config),
  File "/lib/python3.10/site-packages/converter/shieldhit/beam.py", line 52, in __str__
    return self.beam_template.format(
ValueError: Unknown format code 'd' for object of type 'float'

    at new_error (pyodide.asm.js:10:218123)
    at pyodide.asm.wasm
    at pyodide.asm.wasm
    at Module._pythonexc2js (pyodide.asm.js:10:900301)
    at Module.callPyObjectKwargs (pyodide.asm.js:10:119233)
    at Module.callPyObject (pyodide.asm.js:10:119442)
    at PyProxyClass.apply (pyodide.asm.js:10:126886)
    at Object.apply (pyodide.asm.js:10:125914)
    at PythonWorkerBase.convertJSON (src_PythonConverter_PythonWorker_ts.chunk.js:77:55)
    at callback (vendors-node_modules_pmmmwh_react-refresh-webpack-plugin_lib_runtime_RefreshUtils_js-node_mod-1f3a4…:1170:36)

image

Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grzanka grzanka merged commit 64c6905 into master Nov 11, 2022
@grzanka grzanka deleted the 618-add-beam-size-parameters branch November 11, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add beam size parameters
2 participants