Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

222-Add-graph-manager #329

Merged
merged 9 commits into from
Dec 14, 2021
Merged

222-Add-graph-manager #329

merged 9 commits into from
Dec 14, 2021

Conversation

retkiewi
Copy link
Contributor

Fixes #222

@grzanka grzanka added this to the MS 3 milestone Dec 13, 2021
@grzanka
Copy link
Contributor

grzanka commented Dec 13, 2021

@retkiewi please resolve conflicts and remove hardcoded large JSON blob

@retkiewi retkiewi force-pushed the 222-Add-graph-manager branch from fb23d22 to c34c093 Compare December 14, 2021 12:45
grzanka
grzanka approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@retkiewi retkiewi marked this pull request as ready for review December 14, 2021 14:57
@retkiewi retkiewi merged commit 54b9d72 into master Dec 14, 2021
@retkiewi retkiewi deleted the 222-Add-graph-manager branch December 14, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzanka grzanka grzanka approved these changes

Assignees

@Derstilon Derstilon

@retkiewi retkiewi

Labels
None yet
Projects
None yet
Milestone
MS 3
Development

Successfully merging this pull request may close these issues.

Add graph/number manager for each detector mesh view
3 participants
@retkiewi @grzanka @Derstilon