Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add material to world zone (#254) #281

Merged
merged 5 commits into from
Nov 24, 2021
Merged

add material to world zone (#254) #281

merged 5 commits into from
Nov 24, 2021

Conversation

ostatni5
Copy link
Member

close #254
obraz

@ostatni5 ostatni5 added this to the MS 2 milestone Nov 23, 2021
@ostatni5 ostatni5 self-assigned this Nov 23, 2021
@grzanka
Copy link
Contributor

grzanka commented Nov 23, 2021

default material for world zone is air, which is OK.
Can we specify the default material as liquid water for any other zone ? Right now this is still air.

@grzanka
Copy link
Contributor

grzanka commented Nov 23, 2021

@ostatni5 can we clean a bit the material tab ?

I think we can safely hide or remove flat shading and blending

image

@ostatni5
Copy link
Member Author

@ostatni5 can we clean a bit the material tab ?

I think we can safely hide or remove flat shading and blending

image

@Derstilon

@ostatni5
Copy link
Member Author

default material for world zone is air, which is OK. Can we specify the default material as liquid water for any other zone ? Right now this is still air.

Yes

@Derstilon
Copy link
Member

Derstilon commented Nov 24, 2021 •
edited
Loading

@ ostatni5 can we clean a bit the material tab ?

I think we can safely hide or remove flat shading and blending

image

@grzanka
I've left these options to be used because I thought they will be useful for transparent or rough materials. If you want I can delete them and they will be left as default.

@grzanka
Copy link
Contributor

grzanka commented Nov 24, 2021

@grzanka I've left these options to be used because I thought they will be useful for transparent or rough materials. If you want I can delete them and they will be left as default.

What about simply hiding them from UI ?

Derstilon
Derstilon requested changes Nov 24, 2021
View reviewed changes
src/ThreeEditor/js/Sidebar.Material.ZoneMaterial.js Outdated Show resolved Hide resolved
src/ThreeEditor/js/Sidebar.Scene.js Outdated Show resolved Hide resolved
@ostatni5
Copy link
Member Author

@grzanka
obraz

@ostatni5 ostatni5 requested a review from Derstilon November 24, 2021 20:09
grzanka
grzanka previously approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Derstilon
Derstilon previously approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@Derstilon Derstilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Glad you were able to make it work

@ostatni5 ostatni5 dismissed stale reviews from Derstilon and grzanka via f42bb25 November 24, 2021 22:08
@ostatni5 ostatni5 requested a review from Derstilon November 24, 2021 22:10
Derstilon
Derstilon approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@Derstilon Derstilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
You've conquered the wordZone

@ostatni5 ostatni5 merged commit 83aca8a into master Nov 24, 2021
@ostatni5 ostatni5 deleted the feature/254-world-zone-material branch November 24, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Derstilon Derstilon Derstilon approved these changes

@grzanka grzanka grzanka left review comments

Assignees

@ostatni5 ostatni5

Labels
None yet
Projects
None yet
Milestone
MS 2
Development

Successfully merging this pull request may close these issues.

Add Material to World Zone
3 participants
@ostatni5 @grzanka @Derstilon