Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore params (#184) #233

Merged
merged 2 commits into from
Nov 4, 2021
Merged

restore params (#184) #233

merged 2 commits into from
Nov 4, 2021

Conversation

ostatni5
Copy link
Member

@ostatni5 ostatni5 commented Nov 4, 2021

close #184

@ostatni5 ostatni5 added this to the MS 2 milestone Nov 4, 2021
@ostatni5 ostatni5 requested review from grzanka and Derstilon November 4, 2021 11:10
@ostatni5 ostatni5 self-assigned this Nov 4, 2021
@grzanka
Copy link
Contributor

grzanka commented Nov 4, 2021

@ostatni5

In this window:
image

can you replase label

Width [cm] with X side length (width) [cm] and similar for other axis.
This will clearly distinguish side length from half-length convention used in TOPAS

grzanka
grzanka requested changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes in comments

@ostatni5
Copy link
Member Author

ostatni5 commented Nov 4, 2021

obraz

@ostatni5 ostatni5 requested a review from grzanka November 4, 2021 15:09
@grzanka grzanka enabled auto-merge (squash) November 4, 2021 15:50
@grzanka grzanka disabled auto-merge November 4, 2021 15:50
grzanka
grzanka approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good !

@ostatni5 ostatni5 merged commit f970286 into master Nov 4, 2021
@ostatni5 ostatni5 deleted the feature/184-restore-box branch November 4, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzanka grzanka grzanka approved these changes

@Derstilon Derstilon Awaiting requested review from Derstilon

Assignees

@ostatni5 ostatni5

Labels
None yet
Projects
None yet
Milestone
MS 2
Development

Successfully merging this pull request may close these issues.

Add support for RPP
2 participants
@ostatni5 @grzanka