Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jsroot component (#223) #226

Merged
merged 17 commits into from
Nov 4, 2021
Merged

add jsroot component (#223) #226

merged 17 commits into from
Nov 4, 2021

Conversation

ostatni5
Copy link
Member

@ostatni5 ostatni5 commented Oct 30, 2021

close #223

obraz

@ostatni5 ostatni5 requested review from Derstilon and grzanka October 30, 2021 18:43
src/JsRoot/JsRoot.tsx Outdated Show resolved Hide resolved
src/JsRoot/JsRoot.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

Co-authored-by: Leszek Grzanka <leszek.grzanka@gmail.com>
Derstilon
Derstilon previously approved these changes Nov 1, 2021
@grzanka
Copy link
Contributor

grzanka commented Nov 1, 2021

@ostatni5 fix conflicts:

image

@grzanka grzanka added this to the MS 1 milestone Nov 1, 2021
@Derstilon Derstilon force-pushed the feature/223-dummy-jsroot branch from 54e98a0 to 4e40b87 Compare November 2, 2021 14:08
@grzanka
Copy link
Contributor

grzanka commented Nov 2, 2021

Still, the JSROOT panel is not visible in the Results tab. Moreover, some interesting warnings are seen in developer console, indicating problem with canvas size:

image

@grzanka grzanka modified the milestones: MS 1, MS 2 Nov 2, 2021
dependabot bot and others added 3 commits November 3, 2021 01:23
Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 5.14.1 to 5.15.0.
- [Release notes](https://github.com/testing-library/jest-dom/releases)
- [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md)
- [Commits](testing-library/jest-dom@v5.14.1...v5.15.0)

---
updated-dependencies:
- dependency-name: "@testing-library/jest-dom"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@ostatni5 ostatni5 force-pushed the feature/223-dummy-jsroot branch from d5e3f80 to d1a49db Compare November 3, 2021 19:21
grzanka
grzanka previously approved these changes Nov 3, 2021
Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works nice

grzanka
grzanka previously approved these changes Nov 3, 2021
Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still good

@Derstilon Derstilon force-pushed the feature/223-dummy-jsroot branch from c6e45bb to dbe4615 Compare November 3, 2021 20:25
Copy link
Member

@Derstilon Derstilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine

@ostatni5 ostatni5 merged commit c279753 into master Nov 4, 2021
@ostatni5 ostatni5 deleted the feature/223-dummy-jsroot branch November 4, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integrate dummy react component with JSROOT integrated
3 participants