Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/login panel #225

Merged
merged 16 commits into from
Nov 1, 2021
Merged

Feature/login panel #225

merged 16 commits into from
Nov 1, 2021

Conversation

Derstilon
Copy link
Member

@Derstilon Derstilon commented Oct 29, 2021

closes #179
closes #204
Added simple UI for login and simulation running

dependabot bot and others added 11 commits October 26, 2021 01:14
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 16.11.4 to 16.11.6.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@mui/material](https://github.com/mui-org/material-ui/tree/HEAD/packages/mui-material) from 5.0.5 to 5.0.6.
- [Release notes](https://github.com/mui-org/material-ui/releases)
- [Changelog](https://github.com/mui-org/material-ui/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mui-org/material-ui/commits/v5.0.6/packages/mui-material)

---
updated-dependencies:
- dependency-name: "@mui/material"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 17.0.32 to 17.0.33.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react)

---
updated-dependencies:
- dependency-name: "@types/react"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@Derstilon Derstilon added the EuroHPC features created within EuroHPC project label Oct 29, 2021
@Derstilon Derstilon requested review from ostatni5 and grzanka October 29, 2021 19:52
@Derstilon Derstilon linked an issue Oct 29, 2021 that may be closed by this pull request
@grzanka grzanka added this to the MS 1 milestone Oct 29, 2021
grzanka
grzanka previously approved these changes Oct 29, 2021
Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Derstilon
Copy link
Member Author

Derstilon commented Oct 29, 2021

Looks good

@grzanka
image
Can you apply this?

@grzanka
Copy link
Contributor

grzanka commented Oct 29, 2021

Looks good

@grzanka image Can you apply this?

Before committing, can you check it ?
It looks that deepsource doesn't like console (prefers modal or some other way of communication):
image

@Derstilon
Copy link
Member Author

Looks good

@grzanka image Can you apply this?

Before committing, can you check it ? It looks that deepsource doesn't like console (prefers modal or some other way of communication): image

Hmmm. This is all deepsource wanted to fix?

@grzanka
Copy link
Contributor

grzanka commented Oct 30, 2021

Looks good

@grzanka image Can you apply this?

Before committing, can you check it ? It looks that deepsource doesn't like console (prefers modal or some other way of communication): image

Hmmm. This is all deepsource wanted to fix?

Yes. This is why I asked you to cross-check before commiting

src/util/Config.ts Outdated Show resolved Hide resolved
@ostatni5 ostatni5 requested a review from grzanka October 31, 2021 12:49
@ostatni5 ostatni5 force-pushed the feature/login-panel branch from fddb894 to e96e79b Compare October 31, 2021 13:03
Copy link
Member

@ostatni5 ostatni5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obraz

@ostatni5 ostatni5 merged commit 057f4c4 into master Nov 1, 2021
@ostatni5 ostatni5 deleted the feature/login-panel branch November 1, 2021 16:24
@grzanka grzanka added EuroHPC features created within EuroHPC project and removed EuroHPC features created within EuroHPC project labels Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EuroHPC features created within EuroHPC project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send calculation request from frontend to backend Fix removing Zones from the project Add login page
3 participants