# changes to get results from single/list of pages for estimator

[matuszsmig]

This pull request introduces several changes to the EstimatorsSelect component and related services to support fetching estimator data by page dimensions. The most important changes include modifying the EstimatorsSelect component to handle estimator pages data, updating the ShSimulatorService to fetch and aggregate estimator results by pages, and updating the response types to include page dimension information.

Enhancements to EstimatorsSelect component:

• src/WrapperApp/components/Results/EstimatorsSelect/EstimatorsSelect.tsx: Modified the component to accept and use estimatorsPagesData for fetching estimator results by page dimensions. [1] [2] [3]

Updates to ShSimulatorService:

• src/services/ShSimulatorService.tsx: Replaced getJobResult with getEstimatorsPages to fetch estimator results by page dimensions, and added helper functions to prepare page numbers and aggregate results. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

Updates to ResultsPanel component:

• src/WrapperApp/components/Results/ResultsPanel.tsx: Updated to pass estimatorsPagesData to the EstimatorsSelect component. [1] [2]

Changes to response types:

• src/types/ResponseTypes.ts: Added new types EstimatorItem, EstimatorPagesByDimensions, and ResponseGetEstimatorPageResult to support the new data structure for estimator pages. [1] [2]

Changes to request types:

• src/types/RequestTypes.ts: Updated RequestGetJobResult to include pageNumbers for fetching estimator results by pages.

[grzanka]

@matuszsmig before going with review of this PR may we merge first yaptide/yaptide#1243 ? there I have final requests for @SzymanskiBartlomiej

[matuszsmig]

Yes, will there be something to change on frontend side? @grzanka

[grzanka]

Yes, will there be something to change on frontend side? @grzanka

#1882

[matuszsmig]

If it works, then no problem. I will fix merge conflicts later

[grzanka]

#1882 was just merged
also yaptide/yaptide#1243 was merged on backend side

[grzanka]

Do we have everything on backend to test this?

[matuszsmig]

@grzanka this is PR on backend for my changes on frontend yaptide/yaptide#1171

[grzanka]

See comment here: yaptide/yaptide#1171 (comment)

[grzanka]

This is result of SH12A simulation, plot is missing

I would expect this result:

[grzanka]

It seems the UI makes two request to backend, first for pages 0-3 and then another one only for page 1.
Why page 1 is being fetched twice ?

in the input we have first the 0-d scorer, then 1-d scorer, then again two 0-d scorers:

I deliberately changed order of quantities within an output to mix 0-d and 1-d ones...