-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodejs bump in CI #1533
nodejs bump in CI #1533
Conversation
/deploy |
On-demand deploy: succeeded ✅ |
I have a couple of concerns:
|
Testing of python wasn't the main point of the tests. Its related to the converter python module which is being used here via webassembly. I would ideally stick to the latest versions (3.12?) here and cover multiple python version in the tests of the converter itself. I don't see much profit of testing compatibility with converter compiled to wheel file on multiple python versions. I think we could rephrase the README.txt that we need to have a whatever python version which is being able to produce a wheel file for converter. It may be 3.9-3.12. To ensure that wheel is properly produced and working we have enough tests in the converter itself. |
No description provided.