Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs bump in CI #1533

Merged
merged 3 commits into from
Mar 14, 2024
Merged

nodejs bump in CI #1533

merged 3 commits into from
Mar 14, 2024

Conversation

grzanka
Copy link
Contributor

@grzanka grzanka commented Mar 13, 2024

No description provided.

@grzanka grzanka linked an issue Mar 13, 2024 that may be closed by this pull request
@grzanka grzanka self-assigned this Mar 13, 2024
@grzanka grzanka marked this pull request as ready for review March 13, 2024 18:25
@grzanka grzanka requested a review from MatoKnap March 14, 2024 06:36
@grzanka grzanka enabled auto-merge March 14, 2024 06:36
@grzanka
Copy link
Contributor Author

grzanka commented Mar 14, 2024

/deploy

Copy link

On-demand deploy: succeeded ✅
https://github.com/yaptide/ui/actions/runs/8282826903

@MatoKnap
Copy link
Contributor

I have a couple of concerns:

  • In .github/workflows/manual_test.yml you removed python-version 3.9 from strategy matrix. In Requirements it is stated that Python 3.9 and higher. We should change Requirements or change back strategy matrix.
  • In .github/workflows/node.js.yml only one Python version is tested even though multiple version of node are tested using strategy matrix. Should we change that to be the same with manual test?

@grzanka
Copy link
Contributor Author

grzanka commented Mar 14, 2024

I have a couple of concerns:

  • In .github/workflows/manual_test.yml you removed python-version 3.9 from strategy matrix. In Requirements it is stated that Python 3.9 and higher. We should change Requirements or change back strategy matrix.
  • In .github/workflows/node.js.yml only one Python version is tested even though multiple version of node are tested using strategy matrix. Should we change that to be the same with manual test?

Testing of python wasn't the main point of the tests. Its related to the converter python module which is being used here via webassembly. I would ideally stick to the latest versions (3.12?) here and cover multiple python version in the tests of the converter itself. I don't see much profit of testing compatibility with converter compiled to wheel file on multiple python versions.

I think we could rephrase the README.txt that we need to have a whatever python version which is being able to produce a wheel file for converter. It may be 3.9-3.12. To ensure that wheel is properly produced and working we have enough tests in the converter itself.

@grzanka grzanka added this pull request to the merge queue Mar 14, 2024
Merged via the queue into master with commit 631641f Mar 14, 2024
11 checks passed
@grzanka grzanka deleted the 1532-add-nodejs-20x-to-ci branch March 14, 2024 15:31
@grzanka grzanka mentioned this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add node.js 20.x to CI
2 participants