Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/125 bounding zones #144

Merged
merged 17 commits into from
Oct 14, 2021
Merged

Feature/125 bounding zones #144

merged 17 commits into from
Oct 14, 2021

Conversation

ostatni5
Copy link
Member

@ostatni5 ostatni5 commented Oct 13, 2021

Close #125.

dependabot bot and others added 7 commits October 11, 2021 01:57
Bumps [@testing-library/user-event](https://github.com/testing-library/user-event) from 13.2.1 to 13.3.0.
- [Release notes](https://github.com/testing-library/user-event/releases)
- [Changelog](https://github.com/testing-library/user-event/blob/main/CHANGELOG.md)
- [Commits](testing-library/user-event@v13.2.1...v13.3.0)

---
updated-dependencies:
- dependency-name: "@testing-library/user-event"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [web-vitals](https://github.com/GoogleChrome/web-vitals) from 2.1.0 to 2.1.2.
- [Release notes](https://github.com/GoogleChrome/web-vitals/releases)
- [Changelog](https://github.com/GoogleChrome/web-vitals/blob/main/CHANGELOG.md)
- [Commits](GoogleChrome/web-vitals@v2.1.0...v2.1.2)

---
updated-dependencies:
- dependency-name: web-vitals
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 16.10.3 to 16.10.4.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.4.3 to 4.4.4.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.4.3...v4.4.4)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@ostatni5 ostatni5 marked this pull request as draft October 13, 2021 19:34
@ostatni5 ostatni5 self-assigned this Oct 13, 2021
dependabot bot and others added 3 commits October 14, 2021 01:16
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 16.10.3 to 16.10.9.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@types/three](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/three) from 0.132.2 to 0.133.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/three)

---
updated-dependencies:
- dependency-name: "@types/three"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@ostatni5 ostatni5 force-pushed the feature/125-bounding-zones branch from 080c927 to c4498f7 Compare October 14, 2021 12:59
@ostatni5 ostatni5 marked this pull request as ready for review October 14, 2021 13:01
@ostatni5 ostatni5 requested review from grzanka and Derstilon October 14, 2021 13:01
…hree-0.133.1' into feature/125-bounding-zones
…ode-16.10.9' into feature/125-bounding-zones
…ode-16.10.4' into feature/125-bounding-zones
…-library/user-event-13.3.0' into feature/125-bounding-zones
grzanka
grzanka previously approved these changes Oct 14, 2021
Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, good job !

@grzanka grzanka added this to the MS 1 milestone Oct 14, 2021
src/ThreeEditor/js/Sidebar.Geometry.BoundingZone.js Outdated Show resolved Hide resolved
src/ThreeEditor/js/Sidebar.Geometry.BoundingZone.js Outdated Show resolved Hide resolved
src/ThreeEditor/util/BoundingZone.ts Outdated Show resolved Hide resolved
Copy link
Member

@Derstilon Derstilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ostatni5 ostatni5 merged commit f58ab21 into master Oct 14, 2021
@ostatni5 ostatni5 deleted the feature/125-bounding-zones branch October 14, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bounding zones
3 participants