Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smarter docker build #1379

Merged
merged 3 commits into from
Dec 3, 2023
Merged

smarter docker build #1379

merged 3 commits into from
Dec 3, 2023

Conversation

grzanka
Copy link
Contributor

@grzanka grzanka commented Dec 1, 2023

moving preparation of converter wheel into separate docker stage

Copy link
Contributor

@hendzeld hendzeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some old comments are now potentially misleading

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Co-authored-by: Dominik Hendzel <128628266+hendzeld@users.noreply.github.com>
@grzanka grzanka linked an issue Dec 2, 2023 that may be closed by this pull request
@grzanka grzanka marked this pull request as ready for review December 3, 2023 14:15
Copy link
Contributor

@hendzeld hendzeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hendzeld hendzeld added this pull request to the merge queue Dec 3, 2023
Merged via the queue into master with commit fc09aeb Dec 3, 2023
7 checks passed
@hendzeld hendzeld deleted the smarter_docker_build branch December 3, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3-stage Docker build
2 participants