Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use name of page in key in results #1275

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Use name of page in key in results #1275

merged 2 commits into from
Oct 17, 2023

Conversation

ostatni5
Copy link
Member

No description provided.

@ostatni5 ostatni5 linked an issue Oct 16, 2023 that may be closed by this pull request
@ostatni5 ostatni5 temporarily deployed to github-pages October 16, 2023 17:54 — with GitHub Actions Inactive
@ostatni5 ostatni5 requested review from grzanka and Derstilon October 16, 2023 17:54
@grzanka grzanka added EuroHPC features created within EuroHPC project bug labels Oct 16, 2023
@grzanka
Copy link
Contributor

grzanka commented Oct 16, 2023

It works well with normal project, then the bug is fixed, but when running from the files converted using pyodide converter there is an issue.

I've added by hand following section to detect.dat:

Output
    Filename z_profile.bdo
    Geo CylZ_Mesh
    Quantity Dose  
    Quantity Fluence Protons 
    Quantity Fluence Primaries 
    Quantity Fluence Secondary_protons 
    Quantity AvgEnergy Primaries 
    Quantity AvgEnergy Protons 

without grouping:
image
image
image

and here is the output when "Group Quantities" is selected:

image
image
image
image

the quantities appear both grouped and ungrouped

@grzanka
Copy link
Contributor

grzanka commented Oct 16, 2023

The same simulation ran with "Input files" is displayed correctly when using master branch:

image
image

Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix doesn't work with results obtained with "Run with input files" method

@grzanka
Copy link
Contributor

grzanka commented Oct 16, 2023

As for now you can disable grouping when presenting output for "input files" generated output

@ostatni5 ostatni5 temporarily deployed to github-pages October 17, 2023 18:12 — with GitHub Actions Inactive
@ostatni5
Copy link
Member Author

obraz

@ostatni5 ostatni5 requested a review from grzanka October 17, 2023 18:42
@grzanka grzanka added this to the 2023 December milestone Oct 17, 2023
@grzanka grzanka added this pull request to the merge queue Oct 17, 2023
Merged via the queue into master with commit dc06941 Oct 17, 2023
5 checks passed
@grzanka grzanka deleted the 1260-broken-grouping branch October 17, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug EuroHPC features created within EuroHPC project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken grouping
3 participants