-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1196 add dose to medium and let to medium #1233
Conversation
0ef4b7b
to
acc8b0a
Compare
Duplication of Quantities stopped working on this branch: 1196.add.dose.to.medium.and.let.to.medium.by.Derstilon.Pull.Request.1233.yaptide_ui.-.Google.Chrome.2023-10-03.22-31-17.mp4It is working perfectly well on the main branch on github pages deploy: Proton.broad.beam.58.MeV.in.water.-.Google.Chrome.2023-10-03.22-30-04.mp4 |
When running the simulation I get an error from backend:
On the other hand pyodide converter works well: |
…dium-and-let-to-medium
Is it still draft or ready for review? |
Converter changes are merged now, maybe you could update the converter in this PR as well and fix the tests ? |
I've merged new converter and change status to ready |
OK, I will check it. |
@Derstilon take a look as well at yaptide/yaptide#639 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
src/ThreeEditor/components/Sidebar/properties/category/QuantityConfiguration.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs yaptide/yaptide#639 to be merged first
requires yaptide/converter#149 to be merged