Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/58 improve cross section view #120

Merged
merged 10 commits into from
Oct 3, 2021
Merged

Feature/58 improve cross section view #120

merged 10 commits into from
Oct 3, 2021

Conversation

ostatni5
Copy link
Member

@ostatni5 ostatni5 commented Oct 1, 2021

Close #58
Close #100

@ostatni5 ostatni5 requested a review from grzanka October 1, 2021 10:05
@ostatni5 ostatni5 self-assigned this Oct 1, 2021
@grzanka
Copy link
Contributor

grzanka commented Oct 2, 2021

@ostatni5 can we split this PR into two parts ?
I'd suggest moving 05bf76d into a separate PR, as it is quite a complex change and I suspect it may have side effects in the future.
Then rest of the commits (0095894 - 303cff9) from this PR works like charm and I'd like to merge them quickly.

@grzanka
Copy link
Contributor

grzanka commented Oct 2, 2021

OK @ostatni5 no need for separation of this PR, I've made the fix on 78272d0

grzanka
grzanka previously approved these changes Oct 2, 2021
View reviewed changes
Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

grzanka
grzanka approved these changes Oct 2, 2021
View reviewed changes
Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@grzanka grzanka merged commit 461e1fa into master Oct 3, 2021
@grzanka grzanka deleted the feature/58-improve-cross-section-view branch October 3, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzanka grzanka grzanka approved these changes

Assignees

@ostatni5 ostatni5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Vieport.Info component from editor layout improve cross section view
2 participants
@ostatni5 @grzanka