Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix button functionality on simulation card #1172

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Fix button functionality on simulation card #1172

merged 3 commits into from
Sep 4, 2023

Conversation

Derstilon
Copy link
Member

Closes #1168
image
image
image

@grzanka grzanka requested review from ostatni5 and grzanka September 1, 2023 19:32
@grzanka grzanka added the EuroHPC features created within EuroHPC project label Sep 1, 2023
@grzanka
Copy link
Contributor

grzanka commented Sep 1, 2023

In principle it works, but there is also a checkbox "Include simulation results" which has no effect.
Whether being checked or not, simulation results are being added to the JSON.
image

grzanka
grzanka requested changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that is not massive amount of the work, fix the checkbox selecting whether to save results or not. If the work is massive, then remove that checkbox and always save the results

ostatni5
ostatni5 previously approved these changes Sep 2, 2023
View reviewed changes
@Derstilon Derstilon requested a review from grzanka September 4, 2023 14:34
@grzanka grzanka added this pull request to the merge queue Sep 4, 2023
Merged via the queue into master with commit 7ab5bdb Sep 4, 2023
@grzanka grzanka deleted the 1168-save-to-json-job branch September 4, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ostatni5 ostatni5 ostatni5 approved these changes

@grzanka grzanka grzanka approved these changes

Assignees

@Derstilon Derstilon

Labels
EuroHPC features created within EuroHPC project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save results to JSON not working
3 participants
@Derstilon @grzanka @ostatni5