Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test conditional tests #1052

Merged
merged 10 commits into from
Jun 1, 2023
Merged

test conditional tests #1052

merged 10 commits into from
Jun 1, 2023

Conversation

grzanka
Copy link
Contributor

@grzanka grzanka commented May 31, 2023 •
edited
Loading

This dev-ops PR introduces two new testing pipelines intended to be triggered on demand.

The idea is not to run long running tests and deployment after every commit.
This PR introduces new feature. If on a PR discussion a comment appears with /test then a test suite defined in https://github.com/yaptide/ui/pull/1052/files#diff-cb08d37d26dd2d11ba4235a4aff4a4fb8c49779b0f9b5c3884531244d2566d5a will be scheduled for execution.

In a similar way PR comment with /deploy will trigger deployment of docker image to GHCR.

This functionality could be tested only after merge, issuing any /test or /deploy comments in this PR won't have any effect.

The plan for the future:

  1. Keep both on-demand (/test and /deploy triggered) and automated (after every commit) builds for a while to properly test both
  2. Remove building GHCR from automated tests
  3. Reduce automated unit tests to set of short and quick tests (smoke test suite) and run on demand long running tests (i.e. selenium)

I was heavily inspired by:
https://dev.to/zirkelc/trigger-github-workflow-for-comment-on-pull-request-45l2

@grzanka grzanka linked an issue May 31, 2023 that may be closed by this pull request
Test building GHCR on-demand #1051
Closed
@grzanka grzanka self-assigned this May 31, 2023
@grzanka
Copy link
Contributor Author

grzanka commented May 31, 2023

comment

@grzanka
Copy link
Contributor Author

grzanka commented May 31, 2023

test

@grzanka
Copy link
Contributor Author

grzanka commented May 31, 2023

test

@grzanka
Copy link
Contributor Author

grzanka commented May 31, 2023

run

@grzanka grzanka marked this pull request as ready for review May 31, 2023 10:06
@grzanka
Copy link
Contributor Author

grzanka commented May 31, 2023

a

@grzanka
Copy link
Contributor Author

grzanka commented May 31, 2023

aaaa

@grzanka
Copy link
Contributor Author

grzanka commented May 31, 2023

/deploy

@grzanka grzanka enabled auto-merge May 31, 2023 14:14
@grzanka grzanka added this to the 2023 August milestone May 31, 2023
@grzanka grzanka requested review from Derstilon and ostatni5 May 31, 2023 14:20
@grzanka grzanka added this pull request to the merge queue Jun 1, 2023
Derstilon
Derstilon approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@Derstilon Derstilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it

Merged via the queue into master with commit 0479a62 Jun 1, 2023
@grzanka grzanka deleted the 1051-test-building-ghcr-on-demand branch June 1, 2023 08:58
@Derstilon Derstilon added the EuroHPC features created within EuroHPC project label Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Derstilon Derstilon Derstilon approved these changes

@ostatni5 ostatni5 Awaiting requested review from ostatni5

Assignees

@grzanka grzanka

Labels
EuroHPC features created within EuroHPC project
Projects
None yet
Milestone
2023 August
Development

Successfully merging this pull request may close these issues.

Test building GHCR on-demand
2 participants
@grzanka @Derstilon