Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

998 update login panel #1023

Merged
merged 12 commits into from
May 23, 2023
Merged

998 update login panel #1023

merged 12 commits into from
May 23, 2023

Conversation

Derstilon
Copy link
Member

@Derstilon Derstilon commented May 20, 2023 •
edited
Loading

Closes #998 , #985

updated navbar

image image localhost_3000_ (1)
open closed demo

new conditional button visible only when envirioment variable is set cross-env REACT_APP_ALT_AUTH=plg npm run start
image

@Derstilon Derstilon force-pushed the 998-update-login-panel branch 2 times, most recently from d33caf9 to 2e4df24 Compare May 20, 2023 16:40
@Derstilon Derstilon force-pushed the 998-update-login-panel branch from 2e4df24 to 470812e Compare May 20, 2023 16:41
@Derstilon Derstilon requested a review from grzanka May 20, 2023 16:52
@Derstilon Derstilon force-pushed the 998-update-login-panel branch from 3f79cb6 to d1b199a Compare May 20, 2023 17:52
@grzanka
Copy link
Contributor

grzanka commented May 20, 2023

@Derstilon does it fix as well this issue #985 ?

grzanka
grzanka requested changes May 20, 2023
View reviewed changes
Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjust selenium tests as well

@Derstilon Derstilon requested a review from grzanka May 20, 2023 18:43
@Derstilon Derstilon requested review from ostatni5 and grzanka and removed request for grzanka May 21, 2023 10:40
@grzanka
Copy link
Contributor

grzanka commented May 21, 2023

Why the left drawer is not aligned to the top ?

Screenshot 2023-05-21 at 14 44 44

@grzanka

This comment was marked as resolved.

Sign in to view
grzanka

This comment was marked as resolved.

Sign in to view

@grzanka

This comment was marked as resolved.

Sign in to view
@Derstilon Derstilon force-pushed the 998-update-login-panel branch from 08518f9 to 73a00bc Compare May 23, 2023 09:20
@Derstilon
Copy link
Member Author

Where is logout button ? I've deployed frontend with master backend. Login works properly, but I don't see a logout button

image

Should be working now

@Derstilon
Copy link
Member Author

Why the left drawer is not aligned to the top ?

Screenshot 2023-05-21 at 14 44 44

This was stylistic decision. We only have 5 positions on this ui, so I thought it would look better to place it more in the middle. Do you want it back all the way to the top?

@Derstilon Derstilon requested a review from grzanka May 23, 2023 09:42
grzanka
grzanka previously approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@grzanka
Copy link
Contributor

grzanka commented May 23, 2023

Why the left drawer is not aligned to the top ?
Screenshot 2023-05-21 at 14 44 44

This was stylistic decision. We only have 5 positions on this ui, so I thought it would look better to place it more in the middle. Do you want it back all the way to the top?

It looks good, I was just curious about the reasons

@grzanka
Copy link
Contributor

grzanka commented May 23, 2023

@ostatni5 we are waiting for your review

ostatni5
ostatni5 previously approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@ostatni5 ostatni5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On demo looks ok

src/WrapperApp/WrapperApp.tsx Outdated Show resolved Hide resolved
@Derstilon Derstilon dismissed stale reviews from ostatni5 and grzanka via 64c980e May 23, 2023 19:25
@Derstilon Derstilon force-pushed the 998-update-login-panel branch from 64c980e to 20077f1 Compare May 23, 2023 19:25
@Derstilon Derstilon force-pushed the 998-update-login-panel branch from 425776d to 8510953 Compare May 23, 2023 19:46
@Derstilon Derstilon added this pull request to the merge queue May 23, 2023
Merged via the queue into master with commit 80c7262 May 23, 2023
@Derstilon Derstilon deleted the 998-update-login-panel branch May 23, 2023 20:04
@grzanka grzanka mentioned this pull request May 26, 2023
Closed
@Derstilon Derstilon added the EuroHPC features created within EuroHPC project label Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzanka grzanka grzanka approved these changes

@ostatni5 ostatni5 ostatni5 left review comments

@kacper1409 kacper1409 Awaiting requested review from kacper1409

@Bogdan2423 Bogdan2423 Awaiting requested review from Bogdan2423

@lequ0n lequ0n Awaiting requested review from lequ0n

@hendzeld hendzeld Awaiting requested review from hendzeld

Assignees

@Derstilon Derstilon

Labels
EuroHPC features created within EuroHPC project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New button with PLGRID login
3 participants
@Derstilon @grzanka @ostatni5