Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/94 better cross section view #102

Merged
merged 2 commits into from
Sep 27, 2021

Conversation

ostatni5
Copy link
Member

WIP

Closes #94.

@ostatni5 ostatni5 marked this pull request as draft September 24, 2021 13:11
@grzanka
Copy link
Contributor

grzanka commented Sep 24, 2021

Apart from some artefacts where clipping plane is adjacent to the cylinder top/bottom it works great

Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address the comments

@ostatni5 ostatni5 force-pushed the feature/94-better-cross-section-view branch from ccc8b98 to 550756a Compare September 25, 2021 12:12
@ostatni5 ostatni5 marked this pull request as ready for review September 25, 2021 12:13
Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@grzanka grzanka merged commit 822d13d into master Sep 27, 2021
@grzanka grzanka deleted the feature/94-better-cross-section-view branch September 27, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clipping plane display for zones
2 participants