Skip to content

Commit

Permalink
build(deps): bump three from 0.155.0 to 0.156.1 (#1191)
Browse files Browse the repository at this point in the history
* build(deps): bump three from 0.155.0 to 0.156.1

Bumps [three](https://github.com/mrdoob/three.js) from 0.155.0 to 0.156.1.
- [Release notes](https://github.com/mrdoob/three.js/releases)
- [Commits](https://github.com/mrdoob/three.js/commits)

---
updated-dependencies:
- dependency-name: three
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix remove method extended from Object3d

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jakub Niechaj <quban123@gmail.com>
  • Loading branch information
dependabot[bot] and Derstilon authored Sep 7, 2023
1 parent 0d44ed6 commit dec82d1
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 14 deletions.
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"set-interval-async": "^3.0.3",
"signals": "^1.0.0",
"split-grid": "^1.0.11",
"three": "^0.155.0",
"three": "^0.156.1",
"throttle-debounce": "^5.0.0",
"typescript": "^5.2.2",
"use-interval": "^1.4.0",
Expand Down
7 changes: 4 additions & 3 deletions src/ThreeEditor/Simulation/Base/SimulationContainer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,10 @@ export abstract class SimulationSceneContainer<
return result;
}

remove(child: TChild): this {
const result = super.remove(child);
this.editor.signals.objectRemoved.dispatch(child);
remove(...children: TChild[]): this {
const result = super.remove(...children);

for (const child of children) this.editor.signals.objectRemoved.dispatch(child);

return result;
}
Expand Down
6 changes: 3 additions & 3 deletions src/ThreeEditor/Simulation/Zones/ZoneManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ export class ZoneContainer extends SimulationSceneContainer<SimulationZone> {
super(editor, 'Zones', 'ZoneGroup', zoneLoader(editor));
}

remove(zone: SimulationZone): this {
zone.simulationMaterial.decrement();
remove(...zones: SimulationZone[]): this {
for (const zone of zones) zone.simulationMaterial.decrement();

return super.remove(zone);
return super.remove(...zones);
}

// eslint-disable-next-line class-methods-use-this
Expand Down

0 comments on commit dec82d1

Please sign in to comment.