Adds the ability to close when clicking anywhere outside the modal without an overlay #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,7 +25,7 @@ export default function registerAssertHelpers() { | |||
| message = message || 'Dialog triggered by ' + options.openSelector + ' failed to open and close'; | |||
| var dialogContent = [dialogSelector, ':contains(' + options.dialogText + ')'].join(''); | |||
| var self = this; | |||
| return click(options.openSelector).then(function() { | |||
| return click(options.openSelector, options.context).then(function() { | |||
There was a problem hiding this comment.
These options.context lines are a result of #58 to test the dialogCloseSelector while using tether.
|
@kellyselden Could you please fix the one comment (above) and rebase when you have the chance? Things should go green. Thanks. |
kellyselden
force-pushed
the
click-out-closes-without-overlay
branch
from
1f85798
to
7700836
Compare
kellyselden
force-pushed
the
click-out-closes-without-overlay
branch
from
7700836
to
ec78a89
Compare
|
@chrislopresto all should be good now. |
lukemelia
added a commit
that referenced
this pull request
Aug 2, 2015
Adds the ability to close when clicking anywhere outside the modal without an overlay
|
Thanks @kellyselden! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of #55. The use case is treating the modal as a glorified tooltip where it not necessarily the focus of attention, nor the center of the screen. Now you can have the functionality of clicking off closes, while retaining mouse effects like link hovering/clicking and other hover effects.