Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 2.0.0-beta's to use current templates. #44

Merged
merged 1 commit into from
Jun 19, 2015

Commits on Jun 19, 2015

  1. Allow 2.0.0-beta's to use current templates.

    For a few reasons the `semver.satisfies` function does not match
    prelease versions in the same way as we want (it does make sense
    though).
    
    See https://github.com/npm/node-semver#prerelease-tags.
    
    This PR switches over to use the simpler `gt`/`lt` methods which behaves
    much more like what we need with prerelease versions.
    
    A few examples using `semver.lt`:
    
    ```
    > semver.lt('1.12.0-beta.1', '1.13.0')
    true
    > semver.lt('1.13.0-beta.1', '1.13.0')
    true
    > semver.lt('1.12.0', '1.13.0-beta.1')
    true
    > semver.lt('2.0.0', '1.13.0-beta.1')
    false
    > semver.lt('1.13.0', '1.13.0-beta.1')
    false
    > semver.lt('1.13.0-beta.1', '1.13.0-beta.1')
    false
    ```
    rwjblue committed Jun 19, 2015
    Configuration menu
    Copy the full SHA
    5dc0a65 View commit details
    Browse the repository at this point in the history