Avoid Fastboot crash when accessing navigator global
#400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilest
changed the title
navigator globalnavigator global
gilest
changed the title
navigator globalnavigator global
gilest
force-pushed
the
fix/navigator-access
branch
from
a5e5afb
to
44b64f9
Compare
…igator is not present (Fastboot)
gilest
force-pushed
the
fix/navigator-access
branch
from
44b64f9
to
fb5b6df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #399
Would be nice to have a Fastboot test suite but I don't think it needs to block this fix.
I did a naive test by logging the
globalThisobject to make sure it's present in a Fastboot execution – it is.