Metal Modal Approach #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ## Routable Usage | ||
|
|
||
| To assign a modal dialog a dedicated route, place the modal-dialog component directly in a template and transition to the corresponding route. |
There was a problem hiding this comment.
I feel like this can be clearer. Maybe "To have a modal open for a specific route, just drop the {{modal-dialog}} into that route's template"
chrislopresto
force-pushed
the
metal-modal
branch
from
1098043
to
cd0dd8f
Compare
- Add examples to dummy app - Add acceptance tests - Document configurable properties - Structure CSS to be reasonably extensible
chrislopresto
force-pushed
the
metal-modal
branch
from
a7986d8
to
73220ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.